Skip to content

fix(WebSocketShard): buffer native zlib decompression payload #10416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 15, 2024
Merged

fix(WebSocketShard): buffer native zlib decompression payload #10416

merged 4 commits into from
Aug 15, 2024

Conversation

didinele
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Closes #10414

@didinele didinele requested a review from a team as a code owner July 30, 2024 14:29
@didinele didinele requested review from vladfrangu and iCrawl July 30, 2024 14:29
@vercel Vercel
Copy link

vercel bot commented Jul 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 4:10pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 4:10pm

almeidx
almeidx reviewed Jul 30, 2024
View reviewed changes
@didinele @almeidx
refactor: nit
364e0bf 
Co-authored-by: Almeida <almeidx@pm.me>
@codecov Codecov
Copy link

codecov bot commented Jul 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 23.33333% with 23 lines in your changes missing coverage. Please review.

Project coverage is 50.77%. Comparing base (a6de270) to head (23ccc4d).
Report is 1 commits behind head on main.

Files Patch % Lines
packages/ws/src/ws/WebSocketShard.ts 23.33% 23 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10416      +/-   ##
==========================================
- Coverage   50.80%   50.77%   -0.04%     
==========================================
  Files         228      228              
  Lines       20679    20711      +32     
  Branches     1258     1258              
==========================================
+ Hits        10505    10515      +10     
- Misses      10130    10152      +22     
  Partials       44       44
Flag Coverage Δ
ws 51.82% <23.33%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kyranet
kyranet approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure on the shared array which can be erroneously trigger an error if the method is called twice in quick succession, but given the context, I think it's fine.

@kodiakhq kodiakhq bot merged commit defb083 into main Aug 15, 2024
8 checks passed
@kodiakhq kodiakhq bot deleted the fix/native-compress-buffer branch August 15, 2024 16:15
@nyapat nyapat mentioned this pull request Aug 19, 2024
Merged
8 tasks
@almeidx almeidx modified the milestones: ws 2.0.0, voice 0.18.0 Aug 20, 2024
@jakejack13 jakejack13 mentioned this pull request Nov 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/ws

Assignees
No one assigned
Labels
packages:ws semver:patch
Projects
discord.js
Archived in project
Milestone
ws 2.0.0
Development

Successfully merging this pull request may close these issues.

Unexpected end of JSON input when using ZlibNative & zlib-stream transport compression
5 participants
@didinele @vladfrangu @kyranet @SpaceEEC @almeidx